Skip to content

Conversation

meship-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@meship-starkware meship-starkware marked this pull request as ready for review October 5, 2025 07:23
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 5 of 6 files at r1, all commit messages.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion


crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/block_context.cairo line 89 at r1 (raw file):

            sequencer_address=0,
        ),
        starknet_os_config=starknet_os_config,

Keep it without the * in the block context struct, to make the access to chain_id and fee_token_address cheaper

Suggestion:

starknet_os_config=[starknet_os_config],

@meship-starkware meship-starkware force-pushed the meship/small_audit_cosmetic_changes branch from a475a25 to 78b037f Compare October 9, 2025 11:45
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noaov1 reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @meship-starkware)


crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/block_context.cairo line 60 at r2 (raw file):

    execute_deprecated_syscalls_ptr: felt*,
    compiled_class_facts_bundle: CompiledClassFactsBundle*,
    public_keys_hash: felt,

Is this needed?

Code quote:

    public_keys_hash: felt,

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @meship-starkware)

@meship-starkware meship-starkware force-pushed the meship/small_audit_cosmetic_changes branch from 78b037f to 5e79047 Compare October 15, 2025 11:50
Copy link
Collaborator Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 6 files reviewed, 2 unresolved discussions (waiting on @noaov1 and @Yoni-Starkware)


crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/block_context.cairo line 89 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Keep it without the * in the block context struct, to make the access to chain_id and fee_token_address cheaper

Done.


crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/block_context.cairo line 60 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Is this needed?

Done.

@noaov1 noaov1 requested a review from Yoni-Starkware October 15, 2025 12:00
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@noaov1 reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)

@meship-starkware meship-starkware force-pushed the meship/small_audit_cosmetic_changes branch from 5e79047 to 22f8c41 Compare October 15, 2025 12:06
@meship-starkware meship-starkware force-pushed the meship/small_audit_cosmetic_changes branch from 22f8c41 to 3591bff Compare October 15, 2025 12:35
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noaov1 reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 2 of 3 files at r3, 1 of 1 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

@meship-starkware meship-starkware added this pull request to the merge queue Oct 15, 2025
Merged via the queue into main-v0.14.1 with commit e72dc26 Oct 15, 2025
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants