-
Notifications
You must be signed in to change notification settings - Fork 64
starknet_os: move starknet os config outside of block_context #9489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starknet_os: move starknet os config outside of block_context #9489
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware reviewed 5 of 6 files at r1, all commit messages.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion
crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/block_context.cairo
line 89 at r1 (raw file):
sequencer_address=0, ), starknet_os_config=starknet_os_config,
Keep it without the *
in the block context struct, to make the access to chain_id and fee_token_address cheaper
Suggestion:
starknet_os_config=[starknet_os_config],
a475a25
to
78b037f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noaov1 reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @meship-starkware)
crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/block_context.cairo
line 60 at r2 (raw file):
execute_deprecated_syscalls_ptr: felt*, compiled_class_facts_bundle: CompiledClassFactsBundle*, public_keys_hash: felt,
Is this needed?
Code quote:
public_keys_hash: felt,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @meship-starkware)
78b037f
to
5e79047
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 6 files reviewed, 2 unresolved discussions (waiting on @noaov1 and @Yoni-Starkware)
crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/block_context.cairo
line 89 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Keep it without the
*
in the block context struct, to make the access to chain_id and fee_token_address cheaper
Done.
crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/block_context.cairo
line 60 at r2 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Is this needed?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noaov1 reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)
5e79047
to
22f8c41
Compare
22f8c41
to
3591bff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noaov1 reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware reviewed 2 of 3 files at r3, 1 of 1 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
No description provided.